Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Splitting up openAPI specs by version #8

Merged
merged 7 commits into from
Dec 1, 2020
Merged

feat: Splitting up openAPI specs by version #8

merged 7 commits into from
Dec 1, 2020

Conversation

shwetha-manvinkurke
Copy link
Contributor

Fixes

Splitting OpenAPI specs by version

Ref:
https://issues.corp.twilio.com/browse/DI-955
https://code.hq.twilio.com/twilio/yps/pull/56

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • [] I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

eshanholtz
eshanholtz reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .DS_Store to gitignore

spec/json/twilio_trunking_v1.json Outdated Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke mentioned this pull request Nov 30, 2020
Merged
8 tasks
@shwetha-manvinkurke shwetha-manvinkurke merged commit df1ebc6 into main Dec 1, 2020
@shwetha-manvinkurke shwetha-manvinkurke deleted the DI-955 branch December 1, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shwetha-manvinkurke @thinkingserious @eshanholtz