Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add operation IDs #16

Merged
merged 2 commits into from
Dec 14, 2020
Merged

feat: add operation IDs #16

merged 2 commits into from
Dec 14, 2020

Conversation

JenniferMah
Copy link
Contributor

Fixes

Add operation IDs.
https://issues.corp.twilio.com/browse/DI-957

Checklist

  • I acknowledge that all my contributions will be made under the project's license

@JenniferMah JenniferMah mentioned this pull request Dec 10, 2020
Closed
thinkingserious
thinkingserious reviewed Dec 12, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a commit hook that makes sure all operationIDs are unique?

@JenniferMah
Copy link
Contributor Author

JenniferMah commented Dec 14, 2020 •
edited
Loading

Tests for checking for duplicate operationIds will be accomplished in a separate PR and run as PR tests instead of unit tests or a commit hook.

@JenniferMah JenniferMah merged commit 8f877a7 into main Dec 14, 2020
@JenniferMah JenniferMah deleted the DI-957 branch December 14, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JenniferMah @thinkingserious @shwetha-manvinkurke