Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove signature overloading #376

Merged
merged 18 commits into from
Jan 5, 2023
Merged

chore: Remove signature overloading #376

merged 18 commits into from
Jan 5, 2023

Conversation

claudiachua
Copy link
Contributor

@claudiachua claudiachua commented Dec 28, 2022 •
edited
Loading

Internal JIRA Link: DI-2426
Generated Changes: twilio/twilio-node#872

Note: After reviewing the implementation of getPage function - it seems that targetURL param should not be optional

@claudiachua claudiachua mentioned this pull request Dec 28, 2022
Closed
@claudiachua claudiachua changed the title [DI-2426] Remove overload funcs/signature chore: Remove signature overloading Dec 28, 2022
@childish-sambino
Copy link
Contributor

Node tests are failing.

@claudiachua claudiachua mentioned this pull request Jan 4, 2023
Merged
@childish-sambino
Copy link
Contributor

tsc is failing in examples.

@claudiachua
Copy link
Contributor Author

@childish-sambino It's weird how tsc throws error only on fleet.ts, it's the same issue (in twilio-node) previously where params is (option | function) but callback is just function. as (error: Error| null, items) => any was used to solve it previously.

@childish-sambino
Copy link
Contributor

Really strange. Not sure why it works in some cases but not in others. See if changing the if check to this helps

    if (params instanceof Function) {
      callback = params;

@childish-sambino
Copy link
Contributor

Relates to microsoft/TypeScript#37663 (comment)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[twilio-oai-generator-node] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

59.1% 59.1% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claudiachua claudiachua merged commit 71e2f4a into main Jan 5, 2023
@claudiachua claudiachua deleted the DI-2426 branch January 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiachua @childish-sambino