Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0 #847

Merged

Conversation

twilio-product-security
Copy link

@twilio-product-security twilio-product-security commented Dec 23, 2022

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Fixes #846

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 671/1000
Why? Recently disclosed, Has a fix available, CVSS 7.7
Improper Input Validation
SNYK-JS-JSONWEBTOKEN-3180020
Yes No Known Exploit
medium severity 611/1000
Why? Recently disclosed, Has a fix available, CVSS 6.5
Improper Authentication
SNYK-JS-JSONWEBTOKEN-3180022
Yes No Known Exploit
medium severity 611/1000
Why? Recently disclosed, Has a fix available, CVSS 6.5
Improper Restriction of Security Token Assignment
SNYK-JS-JSONWEBTOKEN-3180024
Yes No Known Exploit
medium severity 526/1000
Why? Recently disclosed, Has a fix available, CVSS 4.8
Use of a Broken or Risky Cryptographic Algorithm
SNYK-JS-JSONWEBTOKEN-3180026
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: jsonwebtoken The new version differs by 17 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Use of a Broken or Risky Cryptographic Algorithm

@childish-sambino childish-sambino changed the title [Snyk] Security upgrade jsonwebtoken from 8.5.1 to 9.0.0 chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0 Dec 27, 2022
@childish-sambino childish-sambino changed the base branch from main to 4.0.0-rc December 27, 2022 15:49
@childish-sambino childish-sambino changed the base branch from 4.0.0-rc to main December 27, 2022 15:49
@childish-sambino childish-sambino changed the base branch from main to 4.0.0-rc December 27, 2022 16:06
@childish-sambino childish-sambino force-pushed the snyk-fix-5df44d33b45fb32b90fae9b97dfb988d branch from f50de53 to aeb8407 Compare December 27, 2022 16:09
childish-sambino pushed a commit that referenced this pull request Dec 27, 2022
Relates to #846 and #847

twilio-node v3 supports Node v6/8/10 which are not supported by jsonwebtoken v9. But, after reviewing the vulnerabilities in jsonwebtoken v8, our helper lib is not affected (we don’t verify signatures, only do the signing, and we use default algorithms). This change is to bypass audit failures for v3. Note that v4 does not bypass the audit and uses jsonwebtoken v9.
childish-sambino pushed a commit that referenced this pull request Dec 27, 2022
Relates to #846 and #847

twilio-node v3 supports Node v6/8/10 which are not supported by jsonwebtoken v9. But, after reviewing the vulnerabilities in jsonwebtoken v8, our helper lib is not affected (we don’t verify signatures, only do the signing, and we use default algorithms). This change is to bypass audit failures for v3. Note that v4 does not bypass the audit and uses jsonwebtoken v9.
@childish-sambino childish-sambino merged commit 522d897 into 4.0.0-rc Dec 27, 2022
@childish-sambino childish-sambino deleted the snyk-fix-5df44d33b45fb32b90fae9b97dfb988d branch December 27, 2022 19:43
@Siddhant-K-code
Copy link

@childish-sambino Let's create a new release (version bump) 😄

@childish-sambino
Copy link
Contributor

@Siddhant-K-code New release here: https://github.com/twilio/twilio-node/releases/tag/4.0.0-rc.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants