-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0 #847
Merged
childish-sambino
merged 1 commit into
4.0.0-rc
from
snyk-fix-5df44d33b45fb32b90fae9b97dfb988d
Dec 27, 2022
Merged
chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0 #847
childish-sambino
merged 1 commit into
4.0.0-rc
from
snyk-fix-5df44d33b45fb32b90fae9b97dfb988d
Dec 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childish-sambino
changed the title
[Snyk] Security upgrade jsonwebtoken from 8.5.1 to 9.0.0
chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0
Dec 27, 2022
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSONWEBTOKEN-3180020 - https://snyk.io/vuln/SNYK-JS-JSONWEBTOKEN-3180022 - https://snyk.io/vuln/SNYK-JS-JSONWEBTOKEN-3180024 - https://snyk.io/vuln/SNYK-JS-JSONWEBTOKEN-3180026
childish-sambino
force-pushed
the
snyk-fix-5df44d33b45fb32b90fae9b97dfb988d
branch
from
December 27, 2022 16:09
f50de53
to
aeb8407
Compare
childish-sambino
pushed a commit
that referenced
this pull request
Dec 27, 2022
Relates to #846 and #847 twilio-node v3 supports Node v6/8/10 which are not supported by jsonwebtoken v9. But, after reviewing the vulnerabilities in jsonwebtoken v8, our helper lib is not affected (we don’t verify signatures, only do the signing, and we use default algorithms). This change is to bypass audit failures for v3. Note that v4 does not bypass the audit and uses jsonwebtoken v9.
childish-sambino
pushed a commit
that referenced
this pull request
Dec 27, 2022
Relates to #846 and #847 twilio-node v3 supports Node v6/8/10 which are not supported by jsonwebtoken v9. But, after reviewing the vulnerabilities in jsonwebtoken v8, our helper lib is not affected (we don’t verify signatures, only do the signing, and we use default algorithms). This change is to bypass audit failures for v3. Note that v4 does not bypass the audit and uses jsonwebtoken v9.
childish-sambino
deleted the
snyk-fix-5df44d33b45fb32b90fae9b97dfb988d
branch
December 27, 2022 19:43
@childish-sambino Let's create a new release (version bump) 😄 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Fixes #846
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Recently disclosed, Has a fix available, CVSS 7.7
SNYK-JS-JSONWEBTOKEN-3180020
Why? Recently disclosed, Has a fix available, CVSS 6.5
SNYK-JS-JSONWEBTOKEN-3180022
Why? Recently disclosed, Has a fix available, CVSS 6.5
SNYK-JS-JSONWEBTOKEN-3180024
Why? Recently disclosed, Has a fix available, CVSS 4.8
SNYK-JS-JSONWEBTOKEN-3180026
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: jsonwebtoken
The new version differs by 17 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use of a Broken or Risky Cryptographic Algorithm