Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub release step during deploy #720

Merged
merged 2 commits into from
Jan 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/test-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ jobs:
with:
fetch-depth: 0

- name: Set up Node
uses: actions/setup-node@v2
with:
node-version: 8

- run: npm install

- name: Login to Docker Hub
uses: docker/login-action@v1
with:
Expand All @@ -52,15 +59,14 @@ jobs:
- name: Get tagged version
run: echo "GITHUB_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

- name: Create GitHub Release
uses: sendgrid/dx-automator/actions/release@main
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a footer here as well with the npm package link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it's not something we currently do so just trying to match the existing implementation before enhancing.

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Build and Push image
run: make docker-build && make docker-push

- name: Set up Node
uses: actions/setup-node@v2
with:
node-version: 8

- run: npm install
- name: Publish to NPM
run: |
npm config set //registry.npmjs.org/:_authToken ${NODE_AUTH_TOKEN}
Expand Down