Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove type definition from peerDeps #667

Merged
merged 2 commits into from
Apr 14, 2021
Merged

fix: remove type definition from peerDeps #667

merged 2 commits into from
Apr 14, 2021

Conversation

ktalebian
Copy link
Contributor

Fixes

  • Removing @types/express and @types/qs from peerDependencies

These type definitions should not be a peer dependency:

  1. You do not require type definition if you are using JavaScript
  2. If you are using TypeScript, you may still not require them if you are not planning to use express/qs within your application. If you do, then you can add them to your package.json

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch

ktalebian and others added 2 commits March 29, 2021 12:08
@ktalebian
Remove type definition from peerDeps
320e49b 
* Removing `@types/express` and `@types/qs` from peerDependencies

These type definitions should not be a peer dependency:
1) You do not require type definition if you are using JavaScript
2) If you are using TypeScript, you may still not require them if you are not planning to use express/qs within your application. If you do, then you can add them to your package.json
@thinkingserious
Merge branch 'main' into patch-1
9f3a95a
thinkingserious
thinkingserious approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thinkingserious thinkingserious merged commit 0018eca into twilio:main Apr 14, 2021
@ktalebian ktalebian deleted the patch-1 branch April 15, 2021 17:19
@thinkingserious thinkingserious mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktalebian @thinkingserious