Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: axios expects paramsSerializer not paramSerializer #551

Merged
merged 1 commit into from
Mar 28, 2020
Merged

fix: axios expects paramsSerializer not paramSerializer #551

merged 1 commit into from
Mar 28, 2020

Conversation

stephencaldwell
Copy link
Contributor

Fixes #550

Fixes

Fixes the paramsSerializer passed to axios when making get requests to the twilio REST api.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works - I'm not entirely sure what the best course of validating this change would be.
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

eshanholtz
eshanholtz approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshanholtz eshanholtz merged commit b5c094c into twilio:master Mar 28, 2020
@childish-sambino
Copy link
Contributor

childish-sambino commented Mar 30, 2020 •
edited
Loading

Similar issue here: https://github.com/twilio/twilio-cli-core/blob/master/src/services/cli-http-client.js#L81

twilio/twilio-cli-core#82

@childish-sambino childish-sambino mentioned this pull request Mar 30, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query parameters are not being serialized
3 participants
@stephencaldwell @childish-sambino @eshanholtz