Addressing PR review

twilio · Oct 23, 2020 · 1a7c59b · 1a7c59b
1 parent e08563a
commit 1a7c59b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/jwt/AccessToken.js b/lib/jwt/AccessToken.js
@@ -271,7 +271,7 @@ _.extend(AccessToken.prototype, {
       typ: 'JWT'
     };
 
-    if (this.region && typeof this.region === 'string') {
+    if (this.region && _.isString(this.region)) {
       header.twr = this.region;
     }
 

diff --git a/spec/unit/jwt/AccessToken.spec.js b/spec/unit/jwt/AccessToken.spec.js
@@ -47,7 +47,7 @@ describe('AccessToken', function() {
       });
 
       ['', undefined, null, {}, 1, 0].forEach(function(value) {
-        it('should not twr header if region is ' + value, function() {
+        it('should not add twr header if region is ' + value, function() {
           var token = new twilio.jwt.AccessToken(accountSid, keySid, secret, {region: value});
           var decoded = jwt.decode(token.toJwt(), {complete: true});
 
@@ -67,7 +67,7 @@ describe('AccessToken', function() {
       });
     });
 
-    it('should accept different algorithm', function() {
+    it('should accept different algorithms', function() {
       var validateAlg = function(alg) {
         var token = new twilio.jwt.AccessToken(accountSid, keySid, 'secret');
         var decoded = jwt.decode(token.toJwt(alg), {