-
Notifications
You must be signed in to change notification settings - Fork 301
Add XMPP handling. #42
base: master
Are you sure you want to change the base?
Conversation
Can pull the list of services, or details of a single service, over XMPP. Can subscribe to a service, and receive notifications when that service's status changes. Can unsubscribe as well.
Wow, this is awesome. 👍 A couple of things we need to do before we can merge this in. Can you change |
Huh, that's less work than I expected I'd have to do.
Eep, that wasn't meant to be included. |
@jamezpolley Thanks for fixing the settings, but we still need documentation + tests. Are you interested in writing any of that? If not, this pull request is going to take longer to merge |
@@ -247,7 +249,9 @@ def load_defaults(cls): | |||
if not cls.get_by_slug("warning"): | |||
w = cls(name="Warning", slug="warning", | |||
image="icons/fugue/exclamation.png", | |||
description="The service is experiencing intermittent problems") | |||
description=("The service is experiencing intermittent ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed to a list? Seems to break things for me when initializing the datastore with defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Not meant to be a list. Take out the comma and it should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I do plan to finish this, just haven't had time over the last few months. Plan to work on this over the next week though. |
yeah, cool thanks for getting back to me so quickly On Sat, Jan 26, 2013 at 11:21 PM, James Polley notifications@github.comwrote:
Cheers Sub |
Can pull the list of services, or details of a single service, over
XMPP.
Can subscribe to a service, and receive notifications when that
service's status changes. Can unsubscribe as well.