Skip to content
This repository has been archived by the owner on Apr 5, 2019. It is now read-only.

Add XMPP handling. #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add XMPP handling. #42

wants to merge 2 commits into from

Conversation

jamezpolley
Copy link

Can pull the list of services, or details of a single service, over
XMPP.

Can subscribe to a service, and receive notifications when that
service's status changes. Can unsubscribe as well.

Can pull the list of services, or details of a single service, over
XMPP.

Can subscribe to a service, and receive notifications when that
service's status changes. Can unsubscribe as well.
@kyleconroy
Copy link
Contributor

Wow, this is awesome. 👍

A couple of things we need to do before we can merge this in. Can you change settings.py back to the original settings? Next, we should have some tests around the XMPP endpoints. More importantly, there isn't any documentation on how to actually use the XMPP endpoint.

@jamezpolley
Copy link
Author

Huh, that's less work than I expected I'd have to do.

 Can you change settings.py back to the original settings?

Eep, that wasn't meant to be included.

@kyleconroy
Copy link
Contributor

@jamezpolley Thanks for fixing the settings, but we still need documentation + tests. Are you interested in writing any of that? If not, this pull request is going to take longer to merge

@@ -247,7 +249,9 @@ def load_defaults(cls):
if not cls.get_by_slug("warning"):
w = cls(name="Warning", slug="warning",
image="icons/fugue/exclamation.png",
description="The service is experiencing intermittent problems")
description=("The service is experiencing intermittent ",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed to a list? Seems to break things for me when initializing the datastore with defaults

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Not meant to be a list. Take out the comma and it should work.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezpolley
Copy link
Author

Yep, I do plan to finish this, just haven't had time over the last few months. Plan to work on this over the next week though.

@feczo
Copy link

feczo commented Jan 26, 2013

yeah, cool thanks for getting back to me so quickly
just worked the whole day on putting a stashboard together to my needs
I hacked this version a bit, added some JID filtering because for us
the dashboard and subscriptions are not public
might push a repo later when i cleaned it up

On Sat, Jan 26, 2013 at 11:21 PM, James Polley notifications@github.comwrote:

Yep, I do plan to finish this, just haven't had time over the last few
months. Plan to work on this over the next week though.


Reply to this email directly or view it on GitHubhttps://github.com//pull/42#issuecomment-12734622.

Cheers

Sub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants