docs(model): fully document channel::message
#1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denies missing docs on it and any of it's submodules
github-actions
bot
added
c-model
vilgotf
commented
Jun 9, 2022
| #[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)] | ||
| #[non_exhaustive] | ||
| #[serde(rename_all = "lowercase")] | ||
| pub enum ParseTypes { |
There was a problem hiding this comment.
This type should be renamed to MentionType or AllowedMentionsType, I prefer the first option
There was a problem hiding this comment.
we can refactor allowed mentions separately
There was a problem hiding this comment.
Keeping this unresolved as a reminder
model/src/channel/message/mod.rs
Outdated
Comment on lines
121
to
123
| /// ID of the [`Guild`] the message was sent in. | ||
| /// | ||
| /// [`Guild`]: crate::guild::Guild |
There was a problem hiding this comment.
I tried to add these sort of interlinks where applicable, should they be expanded on or removed entirely?
There was a problem hiding this comment.
i don't know, maybe? i'd like to have some other input on this
7596ff
reviewed
Jun 14, 2022
model/src/channel/message/mod.rs
Outdated
Comment on lines
121
to
123
| /// ID of the [`Guild`] the message was sent in. | ||
| /// | ||
| /// [`Guild`]: crate::guild::Guild |
There was a problem hiding this comment.
i don't know, maybe? i'd like to have some other input on this
vilgotf
commented
Jun 17, 2022
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
7596ff
approved these changes
Jul 7, 2022
|
Could you update this for discord/discord-api-docs#5093? Two birds one stone, I figure it's in scope |
7596ff
pushed a commit
that referenced
this pull request
Jan 6, 2023
* flattens the `allowed_mentions` module into `message` * removes `AllowedMentionsBuilder` (can be brought back into twilight-util if requested) * renames `ParseTypes` to `MentionType` * rewrites the `AllowedMentions` documentation Follow-up PR to discussion in #1792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denies missing docs on it and any of it's submodules.
I'm unhappy with some parts, see my review.