Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use identifier in format #1689

Merged
merged 5 commits into from
May 12, 2022
Merged

refactor: Use identifier in format #1689

merged 5 commits into from
May 12, 2022

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Apr 17, 2022

@github-actions github-actions bot added c-all Affects all crates or the project as a whole c-cache Affects the cache crate c-embed-builder c-gateway Affects the gateway crate c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-model Affects the model crate t-refactor Refactors APIs or code. labels Apr 17, 2022
@vilgotf
Copy link
Member Author

vilgotf commented Apr 17, 2022 •
edited
Loading

use it everywhere.

Except in (routing) test_delete_permission_overwrite and test_update_permission_overwrite.

@7596ff
Copy link
Contributor

7596ff commented Apr 18, 2022

This will have potentially annoying conflicts with #1684

@vilgotf vilgotf changed the base branch from next to zeyla/refactor-tracing-required April 18, 2022 07:33
@github-actions github-actions bot added c-mention Affects the mention crate c-standby Affects the standby crate c-util Affects the util crate c-validate Affects the validate crate t-ci Anything to do with CI. labels Apr 18, 2022
@vilgotf vilgotf force-pushed the vilgotf/refactor/new_format branch from 806b56f to 821a0ec Compare April 18, 2022 07:42
@github-actions github-actions bot added c-util Affects the util crate c-mention Affects the mention crate c-standby Affects the standby crate c-validate Affects the validate crate and removed c-util Affects the util crate c-standby Affects the standby crate c-mention Affects the mention crate c-validate Affects the validate crate labels Apr 18, 2022
@zeylahellyer
Copy link
Member

Do IDEs support this? Having a hard time finding e.g. rust-analyzer issues or triggering support myself.

@github-actions github-actions bot removed c-standby Affects the standby crate c-validate Affects the validate crate labels Apr 19, 2022
@github-actions github-actions bot removed the c-mention Affects the mention crate label Apr 19, 2022
@vilgotf
Copy link
Member Author

vilgotf commented Apr 19, 2022

Do IDEs support this?

That would depend on the editor, potential plugins and what you mean by support. I'm fine with the current level of support.

Having a hard time finding e.g. rust-analyzer issues or triggering support myself.

There's an open issue for RA to resolved captured identifiers.

@Erk-
Copy link
Member

Erk- commented Apr 19, 2022

There's an open issue for RA to resolved captured identifiers.

rust-lang/rust-analyzer#11260

@vilgotf vilgotf added the w-unapproved Proposal for change has *not* been approved by @twilight-rs/core. label Apr 24, 2022
@zeylahellyer zeylahellyer removed the w-unapproved Proposal for change has *not* been approved by @twilight-rs/core. label May 10, 2022
Base automatically changed from zeyla/refactor-tracing-required to next May 11, 2022 05:52
@github-actions github-actions bot added c-standby Affects the standby crate and removed c-standby Affects the standby crate labels May 11, 2022
@vilgotf vilgotf removed the t-ci Anything to do with CI. label May 11, 2022
@vilgotf vilgotf force-pushed the vilgotf/refactor/new_format branch from 10371d2 to a27c39c Compare May 11, 2022 08:44
@github-actions github-actions bot added the c-validate Affects the validate crate label May 11, 2022
@7596ff
Copy link
Contributor

7596ff commented May 11, 2022

This is great for the codebase, but the lack of RA support is unfortunate. I am leaning towards merging it now anyway, since it's better to start using the new convention earlier.

zeylahellyer
zeylahellyer reviewed May 12, 2022
View reviewed changes
@github-actions github-actions bot added the c-mention Affects the mention crate label May 12, 2022
Erk-
Erk- reviewed May 12, 2022
View reviewed changes
@7596ff 7596ff merged commit 22d700b into next May 12, 2022
@7596ff 7596ff deleted the vilgotf/refactor/new_format branch May 12, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7596ff 7596ff 7596ff approved these changes

@Erk- Erk- Erk- approved these changes

@zeylahellyer zeylahellyer zeylahellyer approved these changes

Assignees
No one assigned
Labels
c-all Affects all crates or the project as a whole c-cache Affects the cache crate c-gateway Affects the gateway crate c-gateway-queue Affects the gateway queue crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-lavalink Affects the lavalink crate c-mention Affects the mention crate c-model Affects the model crate c-util Affects the util crate c-validate Affects the validate crate t-refactor Refactors APIs or code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vilgotf @7596ff @zeylahellyer @Erk-