Add user accent_color and banner fields
#1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeylahellyer
added
t-feature
Add the new `accent_color` and `banner` fields. `accent_color` is an integer representation of the RGB color while `banner` is a hash of the user's banner image. These are mutually exclusive. This is documented in the API docs: <discord/discord-api-docs#3448> Closes #1126. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
|
If these are mutually exclusive, is it too far out for Twilight to make an enum represententing them as such instead of two options, which technically could allow for illegal states? |
7596ff
previously approved these changes
Aug 25, 2021
7596ff
previously approved these changes
Sep 8, 2021
AsianIntel
previously approved these changes
Sep 9, 2021
Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
zeylahellyer
dismissed stale reviews from AsianIntel and 7596ff
via
4b84280
I was wrong and they aren't exclusive: {
"id": "640434332485287936",
"username": "zeyla",
"avatar": "a262fa99ab1d42f16751c67886da5640",
"discriminator": "4443",
"public_flags": 0,
"banner": "ce98ed5651d0add1e3ff98782095a7dd",
"banner_color": "#17191c",
"accent_color": 1513756
} |
7596ff
approved these changes
Sep 15, 2021
AsianIntel
approved these changes
Sep 16, 2021
Erk-
reviewed
Sep 16, 2021
7596ff
added a commit
that referenced
this pull request
Sep 17, 2021
Additions Add `Command::kind`, which is a `CommandType`, in order to support Message and User application commands ([#1107] - [@7596ff]). Add `CommandInteractionDataResolved::messages`, which is a list of messages relevant to the interaction ([#1107] - [@7596ff]). Add `MessageType::ContextMenuCommand`, which is relevant to Message and User commands ([#1107] - [@7596ff]). Add the `{Current, User}::{accent_color, banner}` fields ([#1127] - [@zeylahellyer]). Fixes `Command` deserialization no longer errors if the `options` field was missing ([#1112] - [@Erk-]). [#1107]: #1107 [@7596ff]: https://github.com/7596ff [@zeylahellyer]: https://github.com/zeylahellyer
MaxOhn
pushed a commit
to MaxOhn/twilight
that referenced
this pull request
Oct 7, 2021
Add the new `accent_color` and `banner` fields. `accent_color` is an integer representation of the RGB color while `banner` is a hash of the user's banner image. This is documented in the API docs: <discord/discord-api-docs#3448> Closes twilight-rs#1126.
MaxOhn
pushed a commit
to MaxOhn/twilight
that referenced
this pull request
Oct 7, 2021
Additions Add `Command::kind`, which is a `CommandType`, in order to support Message and User application commands ([twilight-rs#1107] - [@7596ff]). Add `CommandInteractionDataResolved::messages`, which is a list of messages relevant to the interaction ([twilight-rs#1107] - [@7596ff]). Add `MessageType::ContextMenuCommand`, which is relevant to Message and User commands ([twilight-rs#1107] - [@7596ff]). Add the `{Current, User}::{accent_color, banner}` fields ([twilight-rs#1127] - [@zeylahellyer]). Fixes `Command` deserialization no longer errors if the `options` field was missing ([twilight-rs#1112] - [@Erk-]). [twilight-rs#1107]: twilight-rs#1107 [@7596ff]: https://github.com/7596ff [@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new
accent_colorandbannerfields.accent_coloris an integer representation of the RGB color whilebanneris a hash of the user's banner image. These are mutually exclusive.This is documented in the API docs: discord/discord-api-docs#3448
Closes #1126.