clarify that macros shadow other macros/functions #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @xabbuh. |
stof
reviewed
Aug 8, 2024
| @@ -75,7 +75,7 @@ via the ``from`` tag: | |||
| .. caution:: | |||
|
|
|||
| As macros imported via ``from`` are called like functions, be careful to | |||
| not override existing functions: | |||
| not shadow existing functions: | |||
There was a problem hiding this comment.
I suggest saying be careful that they shadow existing functions (the current wording makes it look like it is an issue to perform such shadowing, but if you don't intent to use the function, there is no issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4175 (comment)