Update cleaning suspended workspace job #9999
Conversation
etiennejouan
commented
Feb 4, 2025
etiennejouan
commented
- split workspace metadata deletion into multiple queries
- delete all subscriptions when workspace is deleted
etiennejouan
force-pushed
the
ej/worksapce-cleaning-command
branch
from
baacdeb to
5412cf0
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances workspace deletion by implementing a more thorough cleanup process for workspace metadata and subscriptions.
- Added deletion of field and relation metadata through new TypeORM repositories in
packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts - Modified
deleteSubscriptiontodeleteSubscriptionsinpackages/twenty-server/src/engine/core-modules/billing/services/billing-subscription.service.tsto remove all workspace-associated subscriptions - Implemented ordered metadata deletion (relations → fields → objects → migrations → data source → schema) in workspace-manager service for proper referential integrity
- Added FieldMetadataEntity and RelationMetadataEntity to WorkspaceManagerModule's metadata connection
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| } | ||
| await this.billingSubscriptionRepository.delete({ workspaceId }); |
There was a problem hiding this comment.
logic: This bulk delete operation could potentially leave orphaned BillingSubscriptionItems. Consider cascading the delete or explicitly cleaning up related subscription items.
| } | ||
| await this.billingSubscriptionRepository.delete({ workspaceId }); |
There was a problem hiding this comment.
not sure i follow: which additional billingSubscriptions could we have ? why do we not need to cancel them too?
There was a problem hiding this comment.
A workspace can have multiple subscriptions but only one in a not canceled status. (If workspace users have a subscription, cancel it and then subscribe again. Workspace has two subscriptions)
So when a workspace is deleted, we check if there is a not canceled subscription, if yes, we cancel it (in stripe) and then we delete all subscriptions (all in canceled status) in db
Log |
- split workspace metadata deletion into multiple queries - delete all subscriptions when workspace is deleted --------- Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
