Fixed cannot close record table cell header filter #9998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed dropdown hotkey scope on table header cell filter dropdown
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes dropdown focus management and hotkey scope issues in the table header cell filter dropdown functionality.
- Added proper dropdown focus ID handling in
useHandleToggleColumnFilter.tsto prevent multiple dropdowns from conflicting - Fixed hotkey scope management to prevent table hotkeys from triggering when filter dropdown is open
- Integrated
useSetActiveDropdownFocusIdAndMemorizePrevioushook for dropdown state management - Added
usePreviousHotkeyScopehook to properly handle hotkey scope transitions
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
FelixMalfait
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of dropdown focus id, the table header cell filter dropdown wasn't taken into account by this new system that prevents multiple dropdowns from conflicting.
The fix was to just add a dropdown focus id when opening the dropdown.
There was also a bug with the hotkey scope which was staying on table hotkey scope, thus triggering table hotkeys, this PR also fixes that.