Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

148 cant access note without title from kanban board #9817

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Jan 23, 2025

closes twentyhq/core-team-issues#148

  • fixes not openable kanban card when identifier empty
  • update card behavior (onClick open recordPage)
  • fixes right click actionDropdown position

Before

Enregistrement.de.l.ecran.2025-01-23.a.17.05.47.mov

image

After

Enregistrement.de.l.ecran.2025-01-23.a.17.04.13.mov

image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR improves kanban board card interaction by fixing issues with empty identifiers and enhancing click behavior for better record page navigation.

  • Added packages/twenty-front/src/modules/object-record/record-board/utils/StopPropagationContainer.tsx to prevent click event bubbling in card fields
  • Introduced RecordBoardCardBody and RecordBoardCardHeader components to handle empty identifiers and improve card expansion functionality
  • Changed StyledDropdownFallbackAnchor position to 'fixed' in packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx for better dropdown positioning
  • Refactored RecordBoardCard to navigate to record page on click instead of selection
  • Added styled containers (RecordBoardCardBodyContainer and RecordBoardCardHeaderContainer) for consistent card layout and theming

8 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment to address before merging

@martmull martmull enabled auto-merge (squash) January 23, 2025 16:39
@Bonapara
Copy link
Member

Bonapara commented Jan 23, 2025

CleanShot 2025-01-23 at 17 46 50

The input appears to be offset to the bottom; it should be vertically centered above the record name.

262b94b39a2d1b72963784d01715c597d7343289b79227e55fd491ec56c14913

@martmull martmull force-pushed the 148-cant-access-note-without-title-from-kanban-board branch from da69fc2 to 5d63ec0 Compare January 23, 2025 16:57
@martmull martmull merged commit daa8ff1 into main Jan 23, 2025
47 checks passed
@martmull martmull deleted the 148-cant-access-note-without-title-from-kanban-board branch January 23, 2025 17:05
Copy link

sentry-io bot commented Jan 24, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: ((intermediate value)(intermediate value)(intermediate value) || "").trim is not a function /objects/people View Issue
  • ‼️ Invariant Violation: An error occurred! For more details, see the full error text at https://go.apollo.dev/c/err#%7B%2... /object/opportunity/5daa8989-c6e3-4e35-831c-09d... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access note without title from Kanban board
3 participants