-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
148 cant access note without title from kanban board #9817
148 cant access note without title from kanban board #9817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR improves kanban board card interaction by fixing issues with empty identifiers and enhancing click behavior for better record page navigation.
- Added
packages/twenty-front/src/modules/object-record/record-board/utils/StopPropagationContainer.tsx
to prevent click event bubbling in card fields - Introduced
RecordBoardCardBody
andRecordBoardCardHeader
components to handle empty identifiers and improve card expansion functionality - Changed
StyledDropdownFallbackAnchor
position to 'fixed' inpackages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
for better dropdown positioning - Refactored
RecordBoardCard
to navigate to record page on click instead of selection - Added styled containers (
RecordBoardCardBodyContainer
andRecordBoardCardHeaderContainer
) for consistent card layout and theming
8 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
...les/object-record/record-board/record-board-card/components/RecordBoardCardBodyContainer.tsx
Show resolved
Hide resolved
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/object-record/record-board/record-board-card/components/RecordBoardCardBody.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/object-record/record-board/record-board-card/components/RecordBoardCardBody.tsx
Show resolved
Hide resolved
...rc/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
Show resolved
Hide resolved
...rc/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
Outdated
Show resolved
Hide resolved
...s/object-record/record-board/record-board-card/components/RecordBoardCardHeaderContainer.tsx
Show resolved
Hide resolved
...s/object-record/record-board/record-board-card/components/RecordBoardCardHeaderContainer.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-board/utils/StopPropagationContainer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-board/utils/StopPropagationContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a comment to address before merging
...ront/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
Outdated
Show resolved
Hide resolved
da69fc2
to
5d63ec0
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
closes twentyhq/core-team-issues#148 - fixes not openable kanban card when identifier empty - update card behavior (onClick open recordPage) - fixes right click actionDropdown position ## Before https://github.com/user-attachments/assets/696194b8-d7fa-4fc1-a6f9-b46241a262e5  ## After https://github.com/user-attachments/assets/41e296e5-ae16-47f8-b174-7dd21d74188d 
closes twentyhq/core-team-issues#148
Before
Enregistrement.de.l.ecran.2025-01-23.a.17.05.47.mov
After
Enregistrement.de.l.ecran.2025-01-23.a.17.04.13.mov