Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMicrosoftAuthEnabled = true #9812

Merged
merged 11 commits into from
Jan 23, 2025
Merged

isMicrosoftAuthEnabled = true #9812

merged 11 commits into from
Jan 23, 2025

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Jan 23, 2025

No description provided.

@guillim guillim self-assigned this Jan 23, 2025
@guillim guillim enabled auto-merge (squash) January 23, 2025 11:15
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the default value of Microsoft authentication from disabled to enabled in workspace settings, aligning it with other authentication methods like Google and Password auth.

  • Changed default value of isMicrosoftAuthEnabled from false to true in /packages/twenty-server/src/engine/core-modules/workspace/workspace.entity.ts
  • Added migration file /packages/twenty-server/src/database/typeorm/core/migrations/common/1737630672873-workspace-entity-default-microsoft-auth-enabled.ts to update existing database schema

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@guillim guillim merged commit e7ba1c8 into main Jan 23, 2025
35 checks passed
@guillim guillim deleted the microsoft-multi-tenant branch January 23, 2025 11:22
Copy link
Contributor

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-1c071ef9.json

Generated by 🚫 dangerJS against f90454a

eliezer-rodrigues037 pushed a commit to mind-developer/kvoip-v2 that referenced this pull request Jan 23, 2025
DeepaPrasanna pushed a commit to DeepaPrasanna/twenty that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants