fix(twenty-front): allow to connect available provider only #9080
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds conditional rendering of account connection buttons and footer based on workspace authentication settings to prevent server crashes when Google/Microsoft auth is not properly configured.
- Added
currentWorkspaceStatechecks inSettingsAccountsListEmptyStateCard.tsxto only show Google/Microsoft buttons when respective auth is enabled - Added
atLeastOneProviderAvailablecheck inSettingsAccountsConnectedAccountsListCard.tsxto conditionally render "Add account" footer - Updated setup documentation formatting for Microsoft auth environment variables for better readability
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -38,13 +41,15 @@ export const SettingsAccountsListEmptyStateCard = ({ | |||
| <Card> | |||
| <StyledHeader>{label || 'No connected account'}</StyledHeader> | |||
There was a problem hiding this comment.
style: Consider adding explanatory text when auth methods are disabled to guide users on setup
| import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState'; | ||
| import { useRecoilValue } from 'recoil'; | ||
| import { isDefined } from '~/utils/isDefined'; |
There was a problem hiding this comment.
style: consider grouping related imports together (all recoil imports, all utility imports, etc)
Weiko
deleted the
fix/hide-google-and-microsoft-account-when-necessary
branch
|
Thanks @AMoreaux for your contribution! |
Fix #8710
Summary
The Pull Request updates components related to the settings account management feature. The changes ensure the behavior of buttons and the UI dynamically adapts based on the availability of authentication providers retrieved from the current workspace state.
SettingsAccountsConnectedAccountsListCardto dynamically enable the footer button based on workspace authentication settings.SettingsAccountsListEmptyStateCardto conditionally render account connection buttons depending on the availability of enabled authentication providers in the current workspace state.