Select all fields even those not loaded yet when doing Ctrl+A or Cmd+A on Record Table #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced Ctrl+A/Cmd+A functionality in RecordTableWithWrappers component to properly handle selection of all rows, including those not currently loaded in the table view.
- Added
handleSelectAllRowsfunction in/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableWithWrappers.tsxto manage comprehensive row selection - Updated hotkey bindings for both TableHotkeyScope and ActionBarHotkeyScope to use the new selection handler
- Integrated with
useSelectAllRowshook to ensure consistent selection state management across the table
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Devessier
force-pushed
the
select-all-fields-properly
branch
from
2f0c334 to
f564fda
Compare
|
Thanks @Devessier for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #8282 (comment)