Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions setter when opening the command menu #8263

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

bosiraphael
Copy link
Contributor

@bosiraphael bosiraphael commented Oct 31, 2024

Fix standard actions overriding navigate and create commands when opening the command menu.

Before fix:
Capture d’écran 2024-10-31 à 18 08 56

After fix:
Capture d’écran 2024-10-31 à 18 08 34

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this one, to me we should recompte all actions on opening, this looks not to be a robust way!

@bosiraphael
Copy link
Contributor Author

I'm not sure I understand this one, to me we should recompte all actions on opening, this looks not to be a robust way!

The other commands are set inside the CommandMenuEffect inside the AppRouterProviders, but I agree, we should set all commands on open

@charlesBochet charlesBochet merged commit 9b0c742 into main Nov 5, 2024
16 checks passed
@charlesBochet charlesBochet deleted the fix-standard-command-menu-actions-setter branch November 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants