-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Default Demo Login Credentials to noah@demo.dev #7308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request updates the default demo login credentials in the useSignInUpForm
hook, changing the email from 'tim@apple.dev' to 'noah@demo.dev' while maintaining the existing password.
- Modified
packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUpForm.ts
to update the prefilled email address - Aligned the default demo account with the specifications in issue Set default demo account to noah@demo.dev #7304
- Kept the password unchanged as 'Applecar2025'
- Ensures consistency between the demo environment and the desired behavior
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@Bonapara Please review when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution. We still want to keep tim@apple.dev here though. This is because Demo is not automatically seeded so this account will be missing and login won't work in the current state, I don't think this is the correct way to do this.
We could use an env variable for that such as SIGN_IN_PREFILLED_DEFAULT_LOGIN. You can check how it's done with SIGN_IN_PREFILLED.
(cc @charlesBochet)
Thanks for your input, @Weiko! I've now adjusted the code to ensure |
Hey I'm sorry the issue wasn't clear. We actually transitioned to tim@apple.dev to be prefilled for demo but I hadn't updated the README yet because the server hadn't been deployed yet. Thanks a lot for the attempt! |
This PR updates the default login credentials for the demo environment. The current default is set to tim@apple.dev, and we want to change it to: Email: `noah@demo.dev` Password: `Applecar2025` Changes: - Updated default demo login email from tim@apple.dev to noah@demo.dev Resolves twentyhq#7304 --------- Co-authored-by: Félix Malfait <felix@twenty.com>
This PR updates the default login credentials for the demo environment. The current default is set to tim@apple.dev, and we want to change it to:
Email:
noah@demo.dev
Password:
Applecar2025
Changes:
Resolves #7304