10004 tasks will not delete in people view #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes task deletion in the People view by addressing click event handling and drawer closure coordination issues.
- Added
confirmation-modalclass toConfirmationModalfor proper click detection exclusion - Fixed
useListenClickOutsideto respectexcludeClassNamesincomparePixelsmode - Added
emitCloseEventparameter tocloseRightDrawerto prevent unwanted post-deletion updates - Modified
RightDrawerContainerto exclude confirmation modal clicks from triggering drawer closure - Ensured
useDeleteSingleRecordActionusesemitCloseEvent: falsewhen closing drawer after deletion
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
martmull
approved these changes
Feb 5, 2025
eliezer-rodrigues037
pushed a commit
to mind-developer/kvoip-v2
that referenced
this pull request
Feb 7, 2025
Fixes twentyhq#10004 - Fixed `useListenClickOutside` which wasn't working with `excludeClassNames` for `comparePixels` mode - Added `emitCloseEvent` parameter to the `closeRightDrawer` function because closing the right drawer after deleting a note or a task was triggering an update after the deletion. This bug was only for the old version of the command menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10004
useListenClickOutsidewhich wasn't working withexcludeClassNamesforcomparePixelsmodeemitCloseEventparameter to thecloseRightDrawerfunction because closing the right drawer after deleting a note or a task was triggering an update after the deletion.This bug was only for the old version of the command menu.