Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ellipsis for long calendar event names #5267

Closed
FelixMalfait opened this issue May 3, 2024 · 69 comments
Closed

Missing ellipsis for long calendar event names #5267

FelixMalfait opened this issue May 3, 2024 · 69 comments
Assignees
@Lucifer4255
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

I just noticed we don't handle long event names properly:

Screenshot 2024-05-03 at 13 49 23
@FelixMalfait FelixMalfait added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels May 3, 2024
@orinamio
Copy link
Contributor

orinamio commented May 3, 2024

I'll look into this issue. Can you assign me to it?

@FelixMalfait
Copy link
Member Author

Sure! Thanks again @orinamio

heckop added a commit to heckop/twenty that referenced this issue May 11, 2024
@heckop
Issue twentyhq#5267 Fixed: Added a length bound to title
02f1026
@FelixMalfait FelixMalfait mentioned this issue May 13, 2024
Closed
@charlesBochet
Copy link
Member

I have closed #5360 today but the issue still remains!
There is a technical strategy in #5360 comments :)

@charlesBochet charlesBochet mentioned this issue May 23, 2024
Closed
@Nil2000
Copy link

Nil2000 commented Jun 24, 2024 •
edited
Loading

Hi guys, I wanted to work on this and also other good-first-issues.But having problem while setting up locally. Is this the correct way I can set up locally?
I have windows installed in my PC. Instead of using wsl and all Can I not fork and clone the repo and then perform this operations?

@charlesBochet
Copy link
Member

Hi @Nil2000, these are the correct instruction, you'll indeed need WSL and a powerful enough setup on Windows to setup the project

@Nil2000
Copy link

Nil2000 commented Jun 25, 2024

Thanks @charlesBochet for the info I have set up correctly. But now I have another issue I don't see any Calender events to check this. Can you help me produce this event?
I am thinking of sending a Google Meet Request from one of my Gmail accounts to tim@apple.dev. Do you think this will work?

@lucasbordeau lucasbordeau mentioned this issue Jul 25, 2024
Closed
@Faisal-imtiyaz123
Copy link
Contributor

@lucasbordeau Can you assign me this please.

@mittalsam98
Copy link

@Bonapara pls assign this to me, I will look into this

@lucasbordeau
Copy link
Contributor

@Faisal-imtiyaz123 Assigned

@Nabhag8848
Copy link
Contributor

Related, Same with Email, Files, Tasks, Notes.

Files
Screen.Recording.2024-08-30.at.4.52.57.PM.mov
Notes Task

@Nabhag8848
Copy link
Contributor

@FelixMalfait working on it.

@Faisal-imtiyaz123
Copy link
Contributor

@Nabhag8848 This issue is assigned to me. Kindly once check the assignee

@FelixMalfait
Copy link
Member Author

@Faisal-imtiyaz123 because it was assigned a month ago I think @Nabhag8848 assumed you weren't working on it anymore which is fair because ; see https://github.com/twentyhq/twenty/blob/main/.github/CONTRIBUTING.md#getting-started

Thanks again to both of you for your contributions! More than enough work for everyone haha :)

@Nabhag8848
Copy link
Contributor

Thanks @FelixMalfait for mentioning that !

@Faisal-imtiyaz123 you might be interested in checking out this: https://appwrite.io/blog/post/make-open-source-healthier or a even a talk by same speaker https://www.youtube.com/watch?v=YuUt5qABv_k I just went to an event yesterday which talked about what we have gone through rn :) "Contributors role on maintaining Community Health".

@Faisal-imtiyaz123
Copy link
Contributor

Faisal-imtiyaz123 commented Aug 30, 2024 •
edited
Loading

@Nabhag8848 Thanks for sharing it. Will surely see it. @FelixMalfait I am sorry for taking too much time here. Actually I fell unexpectedly sick for 2+ weeks plus some other problems were there.

@Faisal-imtiyaz123 Faisal-imtiyaz123 removed their assignment Sep 4, 2024
@rajeshkrishnait
Copy link

Is this still open? Can i work on it?

@FelixMalfait
Copy link
Member Author

Probably @Nabhag8848 got stuck! So yes feel free to raise a PR! Thank you

(just make sure to look at the previously closed PR)

@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 26, 2024

Assigned to @balvind3r! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@balvind3r
Copy link

image I am having trouble keeping the frontend up...

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 28, 2024

@balvind3r, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

1 similar comment
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 30, 2024

@balvind3r, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 30, 2024

@balvind3r has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@asadath1395
Copy link

I would like to work on this one

@asadath1395 asadath1395 mentioned this issue Nov 16, 2024
Closed
@Bonapara
Copy link
Member

Sure @asadath1395, thanks for contributing!

@tinchil
Copy link

tinchil commented Dec 7, 2024

Hi @Bonapara , Would it be possible to assign myself to this issue? I would like to work on this task

@FelixMalfait
Copy link
Member Author

Thanks @tinchil I think there's already an ongoing PR from @asadath1395 that @bosiraphael will review

@lucasbordeau
Copy link
Contributor

@bosiraphael Is this still relevant ?

@FelixMalfait
Copy link
Member Author

Probably yes #8528

@bosiraphael
Copy link
Contributor

Yes

@Lucifer4255
Copy link
Contributor

Can i work on this issue ? @Bonapara

@Bonapara
Copy link
Member

Sure @Lucifer4255, thanks for contributing!

@Lucifer4255
Copy link
Contributor

Image
Is this ok @Bonapara ?

@Bonapara
Copy link
Member

Hi @Lucifer4255 no, the user chips should still stick to the right.

The issue is there: When the text is too long it should be cropped and not push the user chip outside.

Image

@Lucifer4255
Copy link
Contributor

Lucifer4255 commented Jan 23, 2025 •
edited
Loading

Image

I Think this might be it

I am raising a PR for this

@Bonapara
Copy link
Member

Thanks @Lucifer4255

@Lucifer4255 Lucifer4255 mentioned this issue Jan 23, 2025
Merged
charlesBochet added a commit that referenced this issue Jan 24, 2025
@Lucifer4255 @charlesBochet
fixed ellipsis for calendar events (#9823)
3c85516 
Fixed Missing ellipsis for long calendar event names #5267 introducing
width for the title

Co-authored-by: Charles Bochet <charles@twenty.com>
DeepaPrasanna pushed a commit to DeepaPrasanna/twenty that referenced this issue Jan 27, 2025
@Lucifer4255 @charlesBochet @DeepaPrasanna
fixed ellipsis for calendar events (twentyhq#9823)
95357e9 
Fixed Missing ellipsis for long calendar event names twentyhq#5267 introducing
width for the title

Co-authored-by: Charles Bochet <charles@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucifer4255 Lucifer4255

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Missing ellipsis for long calendar event names asadath1395/twenty