Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remotes][BE] Remote table structure out of sync #4532

Closed
Tracked by #3920
thomtrp opened this issue Mar 18, 2024 · 1 comment · Fixed by #5413
Closed
Tracked by #3920

[Remotes][BE] Remote table structure out of sync #4532

thomtrp opened this issue Mar 18, 2024 · 1 comment · Fixed by #5413
Assignees
@ijreilly
Labels
scope: backend Issues that are affecting the backend side only

Comments

@thomtrp
Copy link
Contributor

thomtrp commented Mar 18, 2024 •
edited by Weiko
Loading

Scope and context

When the remote schema change, we should return informations to the user so he knows the table is out of sync.

Technical inputs

  • add a new field in payload syncDetails --> to be defined
  • in findAvailableRemoteTablesByServerId function, add a function call that calculates this info for the synced table
  • this function should fetch the table structure and compare with the foreign tables
@thomtrp thomtrp self-assigned this Mar 18, 2024
@thomtrp thomtrp converted this from a draft issue Mar 18, 2024
@thomtrp thomtrp added scope: backend Issues that are affecting the backend side only type: chore labels Mar 18, 2024
@thomtrp thomtrp changed the title [Inv] Warn user when remote data are not up to date Warn user when remote data are not up to date Mar 18, 2024
@charlesBochet charlesBochet changed the title Warn user when remote data are not up to date Warn user when remote metadata are not up to date Mar 19, 2024
@Weiko Weiko changed the title Warn user when remote metadata are not up to date Warn user when remote table structures are not up to date Mar 19, 2024
@Weiko Weiko changed the title Warn user when remote table structures are not up to date Warn user when remote table structures and metadata are not up to date Mar 19, 2024
@thomtrp thomtrp changed the title Warn user when remote table structures and metadata are not up to date Warn user when remote table structures and metadata are not up to date (?) Apr 2, 2024
@thomtrp thomtrp changed the title Warn user when remote table structures and metadata are not up to date (?) Warn user when remote table structures and metadata are not up to date Apr 3, 2024
@thomtrp thomtrp moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Apr 8, 2024
@thomtrp thomtrp moved this from 🏗 In progress to 🔖 Planned in 🎯 Roadmap & Sprints Apr 8, 2024
@thomtrp thomtrp changed the title Warn user when remote table structures and metadata are not up to date [Opened questions] Warn user when remote table structures and metadata are not up to date Apr 19, 2024
@thomtrp thomtrp changed the title [Opened questions] Warn user when remote table structures and metadata are not up to date [Remotes][Questions?] Remote table structure out of sync Apr 19, 2024
@thomtrp thomtrp assigned ijreilly and unassigned thomtrp Apr 19, 2024
@ijreilly ijreilly changed the title [Remotes][Questions?] Remote table structure out of sync [Remotes][BE][Questions?] Remote table structure out of sync Apr 22, 2024
@ijreilly
Copy link
Collaborator

ijreilly commented Apr 22, 2024 •
edited
Loading

In V1, if there is a column change (name change - that we will perceive as deletion of a column and creation of a new one - or type change or creation / deletion), it will trigger a deletion and re-creation of column on our hand, deleting the relation.

@ijreilly ijreilly mentioned this issue May 2, 2024
Closed
@ijreilly ijreilly changed the title [Remotes][BE][Questions?] Remote table structure out of sync [Remotes][BE] Remote table structure out of sync May 2, 2024
@ijreilly ijreilly moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints May 2, 2024
@ijreilly ijreilly mentioned this issue May 14, 2024
Merged
@ijreilly ijreilly moved this from 🏗 In progress to 👀 In review in 🎯 Roadmap & Sprints May 15, 2024
Weiko pushed a commit that referenced this issue May 15, 2024
@ijreilly
Compare distant tables schema with remote tables schema (#5413)
38eb293 
Closes #4532 and part of #5062
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🎯 Roadmap & Sprints May 15, 2024
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
@ijreilly
Compare distant tables schema with remote tables schema (twentyhq#5413)
37a888a 
Closes twentyhq#4532 and part of twentyhq#5062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ijreilly ijreilly

Labels
scope: backend Issues that are affecting the backend side only
Projects
🎯 Roadmap & Sprints
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compare distant tables schema with remote tables schema twentyhq/twenty
4 participants
@charlesBochet @thomtrp @ijreilly and others