Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Detail - Add field row dropdowns #2158

Closed
Tracked by #1811
thaisguigon opened this issue Oct 20, 2023 · 0 comments · Fixed by #2200
Closed
Tracked by #1811

Object Detail - Add field row dropdowns #2158

thaisguigon opened this issue Oct 20, 2023 · 0 comments · Fixed by #2200
Assignees
Labels
scope: front Issues that are affecting the frontend side only

Comments

@thaisguigon
Copy link
Contributor

thaisguigon commented Oct 20, 2023

Context

See #1765 and #1769

For this issue:

  • In the "Object Detail" page, in the fields table, open a dropdown when the "three dots" icon button of a row is clicked.
  • Add the following menu items to the dropdowns:
    • For "Active" field rows:
      • "Edit" for custom fields OR "View" for standard fields: Clicking on this menu item navigates to the "Object Field Edit" page (/settings/objects/[PLURAL_OBJECT_NAME]/[FIELD_NAME])
      • "Disable": Clicking on this menu item disables the field (use useUpdateOneMetadataField to set isActive to false).
    • For "Disabled" field rows:
      • "Activate": Clicking on this menu item activates the field (use useUpdateOneMetadataField to set isActive to true).
      • "Erase" for custom fields only: Clicking on this menu item deletes the field (use useDeleteOneMetadataField).

Figma

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=11336%3A63490&mode=design&t=EynOEhEsP06qxkYt-1

Active - Custom

Image

Active - Standard

Image

Disabled - Custom

Image

Behavior

GIVEN I am on the "Object Detail" page
WHEN I open an active custom field row dropdown
THEN I see an "Edit" and "Disable" menu items

GIVEN I am on the "Object Detail" page
WHEN I open an active standard field row dropdown
THEN I see a "View" and "Disable" menu items

GIVEN I am on the "Object Detail" page
WHEN I open an active field row dropdown
AND I click on the "Edit" or "View" menu item
THEN I navigate to the "Object Field Edit" page

GIVEN I am on the "Object Detail" page
WHEN I open an active field row dropdown
AND I click on the "Disable" menu item
THEN the field is disabled

GIVEN I am on the "Object Detail" page
WHEN I open an disabled custom field row dropdown
THEN I see an "Activate" and "Erase" menu items

GIVEN I am on the "Object Detail" page
WHEN I open an disabled standard field row dropdown
THEN I see an "Activate" menu item

GIVEN I am on the "Object Detail" page
WHEN I open a disabled field row dropdown
AND I click on the "Activate" menu item
THEN the field is enabled

GIVEN I am on the "Object Detail" page
WHEN I open a disabled custom field row dropdown
AND I click on the "Erase" menu item
THEN the field is deleted

@thaisguigon thaisguigon added scope: front Issues that are affecting the frontend side only blocked: conflict/dependency labels Oct 20, 2023
@thaisguigon thaisguigon moved this from 🆕 New to 🔖 Planned in 🎯 Roadmap & Sprints Oct 20, 2023
@thaisguigon thaisguigon moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Oct 23, 2023
@thaisguigon thaisguigon moved this from 🏗 In progress to 🔖 Planned in 🎯 Roadmap & Sprints Oct 23, 2023
@thaisguigon thaisguigon moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Oct 23, 2023
@thaisguigon thaisguigon moved this from 🏗 In progress to 👀 In review in 🎯 Roadmap & Sprints Oct 23, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🎯 Roadmap & Sprints Oct 24, 2023
charlesBochet added a commit that referenced this issue Oct 24, 2023
* feat: activate and disable objects

Closes #2144, Closes #2148, Closes #2154

* feat: activate, disable and erase fields in Object Detail

Closes #2158

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: front Issues that are affecting the frontend side only
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants