Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map iterator #69

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Map iterator #69

merged 9 commits into from
Dec 19, 2024

Conversation

HaoboGu
Copy link
Contributor

@HaoboGu HaoboGu commented Dec 6, 2024

This PR aims to provide an iterator on map values, related to #65 and #65 (comment)

@HaoboGu
wip(map): map iterator
a2e2f23 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Contributor Author

HaoboGu commented Dec 6, 2024

Current implementation is a very initial implementation. It requires a data buffer for creating MapItemIter and ANOTHER data buffer when getting the next item. I cannot re-use the data buffer since if current page iter ends, I have to loop over again to find the next page iter. I think there should be better solution to eliminate the extra data buffer needed, but I don't know how

@HaoboGu
feat(map): finish the map iterator
a05daa2 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Contributor Author

HaoboGu commented Dec 11, 2024 •
edited
Loading

@diondokter Hi! I think I've finished it. According my tests, compared with just loading all items, the iterator can get 300x speedup(6482ms -> 22ms). Do you have any comments on this PR?

@HaoboGu HaoboGu force-pushed the feat/map_iterator branch 2 times, most recently from e759543 to c297631 Compare December 11, 2024 08:29
@HaoboGu
refactor(map): clean map iterator api, add docs
0b0dc63 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu mentioned this pull request Dec 11, 2024
Closed
diondokter
diondokter requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@diondokter diondokter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Good start, but some more work is needed

src/map.rs Show resolved Hide resolved
src/map.rs Outdated Show resolved Hide resolved
src/map.rs Outdated Show resolved Hide resolved
src/map.rs Outdated Show resolved Hide resolved
src/map.rs Outdated Show resolved Hide resolved
src/map.rs Show resolved Hide resolved
@diondokter
Copy link
Collaborator

300x speedup is pretty dope :D

@diondokter diondokter mentioned this pull request Dec 11, 2024
Closed
@HaoboGu
feat(map): fix PR comments, add test
c09208c 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu requested a review from diondokter December 12, 2024 06:41
diondokter
diondokter reviewed Dec 13, 2024
View reviewed changes
src/map.rs Outdated Show resolved Hide resolved
src/map.rs Show resolved Hide resolved
src/map.rs Show resolved Hide resolved
@HaoboGu
fix(map): use the correct first page of the map for iterator
037c188 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
doc(map): update the reminder
3fea43a 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(map): add auto repair to iterator, update test
c8fe5f0 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
doc(map): improve map iterator doc, add a warning
c897734 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
chore: update changelog
4ed9034 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu requested a review from diondokter December 19, 2024 06:29
diondokter
diondokter approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@diondokter diondokter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the work!

@diondokter
Copy link
Collaborator

Ah there's some updating I need to do which is why the CI fails. I'll merge regardless

@diondokter diondokter merged commit fac5dfa into tweedegolf:master Dec 19, 2024
3 of 5 checks passed
@diondokter
Copy link
Collaborator

Alright, everything has been fixed up and tested.
4.0.0 is now released with this PR in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diondokter diondokter diondokter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoboGu @diondokter