Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module extension for nodejs toolchain #505

Merged
merged 14 commits into from
Apr 30, 2024
Merged

Conversation

aherrmann
Copy link
Member

@aherrmann aherrmann commented Apr 22, 2024

Closes #480

Provides a module extension to configure a Nix provided NodeJS toolchain.

The extension configures one toolchain per supported platform. This follows the pattern used by the corresponding repository macro.

At this point the module extension is not yet configurable. I.e. it will always use the nodejs attribute path in the default @nixpkgs repository. Making the toolchain configurable is left open for a follow-up PR.

Note that users can still override this toolchain with their own custom toolchain by invoking the repository macro directly. Users can also override the @nixpkgs repo to change the NodeJS toolchain.

  • test-case for nix_nodejs toolchains extension
  • nix_nodejs module extension scaffolding
  • testing/nodejs: use nix_repo module extensions
  • Remove NodeJS toolchain from non_module_deps
  • Generate and register NodeJS toolchains
  • Register default NodeJS toolchain
  • factor out common nodejs definitions
  • Factor out nixkgs_nodejs
  • Use nixpkgs_nodejs in module extension
  • factor out nodejs toolchain snippet
  • re-use nodejs toolchain snippet

@aherrmann aherrmann requested a review from benradf as a code owner April 22, 2024 13:30
@aherrmann aherrmann requested review from benradf and avdv April 22, 2024 13:30
@aherrmann aherrmann merged commit 96c89bf into master Apr 30, 2024
13 checks passed
@aherrmann aherrmann deleted the bzlmod-nodejs-toolchain branch April 30, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module extension for NodeJS toolchain
2 participants