Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: add experiments=nocoverageredesign for go_sdk in 1.20+ #440

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

lizan
Copy link
Contributor

@lizan lizan commented Nov 7, 2023

rules_go adds experiments=nocoverageredesign automatically. rules_nixpkgs doesn't add this, so bazel coverage fails with testing: cannot use -test.coverprofile because test binary was not built with coverage enabled.

@lizan lizan requested a review from benradf as a code owner November 7, 2023 01:49
@lizan
Copy link
Contributor Author

lizan commented Nov 14, 2023

@benradf can you take a look on this when you have a moment?

@benradf benradf added the merge-queue merge on green CI label Nov 15, 2023
@mergify mergify bot merged commit e632be8 into tweag:master Nov 15, 2023
15 checks passed
@mergify mergify bot removed the merge-queue merge on green CI label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants