Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set -Wno-elaborated-enum-base on Darwin #382

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

aherrmann
Copy link
Member

@aherrmann aherrmann commented May 9, 2023

To work around llvm/llvm-project#48757.
Without this change builds on MacOS can fail with errors along the lines of

/.../process-wrapper '--timeout=0' '--kill_delay=15' external/nixpkgs_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections -x c++ '-std=c++0x' -MD -MF bazel-out/darwin_arm64-opt-exec-C7777A24/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.d '-frandom-seed=bazel-out/darwin_arm64-opt-exec-C7777A24/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.o' '-DBAZEL_CURRENT_REPOSITORY="com_google_absl"' -iquote external/com_google_absl -iquote bazel-out/darwin_arm64-opt-exec-C7777A24/bin/external/com_google_absl -g0 -g0 '-std=c++17' -no-canonical-prefixes -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/com_google_absl/absl/time/internal/cctz/src/time_zone_lookup.cc -o bazel-out/darwin_arm64-opt-exec-C7777A24/bin/external/com_google_absl/absl/time/internal/cctz/_objs/time_zone/time_zone_lookup.o)
In file included from external/com_google_absl/absl/time/internal/cctz/src/time_zone_lookup.cc:26:
In file included from /nix/store/0dh2hqgrnccqlv7hihxh7s9gsz0sy8yz-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/CFTimeZone.h:13:
/nix/store/0dh2hqgrnccqlv7hihxh7s9gsz0sy8yz-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:474:9: error: non-defining declaration of enumeration with a fixed underlying type is only permitted as a standalone declaration; missing list of enumerators? [-Welaborated-enum-base]
typedef CF_ENUM(CFIndex, CFComparisonResult) {

Reported on Bazel Community Slack.

@aherrmann aherrmann requested a review from benradf as a code owner May 9, 2023 13:59
@aherrmann aherrmann added the merge-queue merge on green CI label May 9, 2023
@mergify mergify bot merged commit dae7e53 into master May 9, 2023
@mergify mergify bot deleted the elaborated-enum-base branch May 9, 2023 14:48
@mergify mergify bot removed the merge-queue merge on green CI label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants