Implement remaining nix_pkg tags #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
aherrmann
changed the title
benradf
approved these changes
Apr 17, 2023
Comment on lines
-60
to
+49
| "$(locations @output-filegroup-test//:include)", | ||
| "$(locations {})".format(nix_pkg("rules_nixpkgs_core_testing", "output-filegroup-test", "//:include")), | ||
| ], | ||
| data = ["@output-filegroup-test//:include"], | ||
| data = [nix_pkg("rules_nixpkgs_core_testing", "output-filegroup-test", "//:include")], |
There was a problem hiding this comment.
I was a bit confused why the nix_pkg module extension was being used like this, but now I see nix_pkg here is a helper macro from defs.bzl.
There was a problem hiding this comment.
Probably something to make clear in the docs. Or, if we end up getting local_use_repo the problem would go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #364
Part of #183.
Implement the remaining
local_fileandlocal_exprnix_pkgtags.Add support for
nixoptshandling. (Apart from location expansion, see below).Ensure each of them is tested in testing/core.
Note on location expansion: The implementation of location expansion for repository rules needs to know the labels as seen at the definition site of the location expansion expression, i.e. the user's MODULE.bazel file. But, the module extension implementation only sees the resolved labels, not their raw string form. The repository rules were able to work around this using a wrapper macro. But, MODULE.bazel files cannot call macros, meaning this workaround is not available.