Add nixpkgs_http_repository #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more general version of nixpkgs_git_repository that is not limited to the specific archives offered by Github, but can be applied to other HTTP provided repositories in general. This is a pre-requisite for some of the tags for the new Bazel module extension designed in design/bzlmod/README.md, in particular the http and github tags.
aherrmann
commented
Mar 22, 2023
|
|
||
| A unique name for this repository. | ||
|
|
||
| url: String |
There was a problem hiding this comment.
Most of this docstring is taken and adapted from http_archive.
benradf
approved these changes
Mar 22, 2023
| }, | ||
| ) | ||
|
|
||
| def nixpkgs_http_repository( | ||
| *, |
There was a problem hiding this comment.
I hadn't seen this syntax before. It makes everything after * be a keyword argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
nixpkgs_http_repositorya more general version ofnixpkgs_git_repositorythat is not limited to the specific archives offered by Github, but can be applied to other HTTP provided repositories in general.This new rule will be used to implement the
httpandgithubtags in the Nix repository module extension as described indesign/bzlmod/README.md.nixpkgs_git_repositoryis modified to callnixpkgs_http_repositoryitself.