Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Mergify): configuration update #352

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

layus
Copy link
Collaborator

@layus layus commented Mar 15, 2023

This change has been made by @layus from Mergify config editor.

Signed-off-by: Guillaume Maudoux <null>
@layus layus requested a review from benradf as a code owner March 15, 2023 20:16
@layus
Copy link
Collaborator Author

layus commented Mar 15, 2023

Trying to fix the issue seen in #350 where mergify did not kick in (https://github.com/tweag/rules_nixpkgs/pull/350/checks?check_run_id=12016141108) due to the fact that mergify now fails instead of using a random org user to perform the merge, as announced in https://changelog.mergify.com/changelog/rebasing-pull-requests-with-a-random-user-is-deprecated. At least that is what I learned in Mergifyio/mergify#5075. Another option would be to use a more advanced merge method, as our paid plan allows, but we need a bot account for that. Is there an official Tweag bot for that ?

Copy link
Member

@benradf benradf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@benradf benradf added the merge-queue merge on green CI label Mar 16, 2023
@layus layus merged commit 0dc6b3d into master Mar 16, 2023
@layus layus deleted the mergify/layus/config-update branch March 16, 2023 14:58
@mergify mergify bot removed the merge-queue merge on green CI label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants