Separate toolchains/java tests and run with bzlmod enabled #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`native.register_toolchains` can no longer be used in repository macros under bzlmod. Instead, toolchain registration has to occur in the MODULE.bazel file.
Configures a nixpkgs provided Java toolchain in both WORKSPACE and bzlmod mode. In bzlmod mode we need to import a range of transitive dependencies, like rules_java, platforms, or even remote_java_tools, because the Java toolchain is defined in an ad-hoc local module extension. These should no longer be needed at the use-site once nixpkgs_java_configure is a module extension in rules_nixpkgs_java.
|
The correct configuration for dpulls is to have this PR based on the dependency branch. However, due to the CI configuration this doesn't run CI. So I'm switch the base branch back to master. Perhaps we should change the CI configuration to allow CI on all PRs. |
8 tasks
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #319
Creates a new module in
testing/javaand moves the tests fromtoolchains/javainto this module following the motivation from tweag/rules_sh#41.Makes the Java toolchain registration optional, as the corresponding
native.register_toolchainscannot be called in a repository macro under bzlmod.Building
toolchains/javawith bzlmod enabled raised a problem: The module depends onrules_nixpkgs_core, but cannot find it in the Bazel Central Registry. The obvious solution,local_path_overridedoes not work, because that is only allowed in the main module, butrules_nixpkgs_javais a library module. The next best solution--override_moduleis awkward, because that flag requires an absolute path, does not support%workspace%expansion, and must not be set for the module it is overriding.The solution chosen in this PR is to use a local Bazel registry. The corresponding configuration flag
--registrydoes support%workspace%expansion and is therefore easier to configure.