Skip writing to the remote cache without API key #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For foreign PRs (e.g. dependabot) access to the repository secrets is not
permitted, so the API key for Buildbuddy ends up as empty.
This leads to an error later:
```
WARNING: BES was not properly closed
ERROR: The Build Event Protocol upload failed: Not retrying publishBuildEvents, no more attempts left: status='Status{code=UNAUTHENTICATED, description=failed to parse API key: missing API Key, cause=null}' UNAUTHENTICATED: UNAUTHENTICATED: failed to parse API key: missing API Key UNAUTHENTICATED: UNAUTHENTICATED: failed to parse API key: missing API Key
```
Make the workflow get triggered either by pushes to the default branch, by pull requests targeting the default branch, or by manually triggering it from Github's UI.
avdv
force-pushed
the
ci-build-buddy-readonly
branch
from
cb2628e
to
bd06606
Compare
avdv
changed the title
bryanhonof
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Looks good to me. Could we perhaps also make this a successor to #248? I believe I've overengineered that one. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For foreign PRs (e.g. dependabot) access to the repository secrets is not permitted, so the API key for Buildbuddy ends up as empty.
This leads to an error later:
This PR is a simpler alternative to the approach taken in #248: instead of artificially drawing a line between pull_request and push events this change will just not try to write to the remote cache if the API key is not set (for whatever reason).
Update: I just noticed that dependabot actually does create a branch in this repository, which triggers a push. But still, it has no access to the repository secrets. So the approach in #248 would not fix this, IMO.
Fixes #243