Update bzlmod dependencies and enhance separation of components #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rules_go` is available on the central registry now. So add it and update http_archive references to version 0.33.0 to match the bzlmod version.
This enables every module to pass in the required toolchains explicitly.
... instead of `io_tweag_rules_nixpkgs`.
This is needed since the java toolchain is loaded using `@rules_nixpkgs_java` in `core/docs/dependencies_2.bzl` which is loaded in the WORKSPACE for every toolchain - including the java toolchain, where it must refer to itself.
That sounds like a reasonable approach to me, if feasible. FWIW modules also introduce a notion of dev-dependencies, so, perhaps in that case the components needed for Stardoc could simply be marked as such and wouldn't be needed for regular use. cc @fricklerhandwerk any thoughts? I think you're more familiar with this part than me. |
aherrmann
reviewed
Aug 11, 2022
aherrmann
approved these changes
Sep 5, 2022
fricklerhandwerk
approved these changes
Sep 5, 2022
Yes, I created an issue to track this: #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes bzlmod migration a step further and tries to lay ground for future work in that area.
Currently, there are a few components / modules which were all depending on each other:
coreccgojavaposixrustpythonnixpkgs(the everything component)It should be possible to require a specific toolchain with only pulling in the required dependencies.
This PR adds a
toolchainsparameter to therules_nixpkgs_dependenciesfunction signalling which toolchain is required.Interestingly, every component depends on java, posix and the cc toolchain (even the core). This is because of the stardoc dependency which consists of a
java_binary...IMO, it would be a good idea to separate the docs generation into another component, in order to get rid of the excess dependencies. WDYT?