Fix Rust example on macOS #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's added by nixpkgs automagically starting with commit: NixOS/nixpkgs@77550df (included in nixpkgs releases starting with 19.03)
libstdc++ isn't available on Darwin, so it's safe to assume that libc++ is used there. I didn't find a way to detect which one of them is actually used in stdenv so far.
It seems to be required only by Rust right now, but it might be because we don't really test CC toolchain (see #209). Add it for all Darwin targets for now to fix Rust case.
Following #209, add --incompatible_enable_cc_toolchain_resolution flag to build action in Rust example so that changes to CC toolchain take effect.
#187 should be fixed now
| ) | ||
| IS_CLANG=( | ||
| $( | ||
| ${cc}/bin/cc -v 2>&1 | grep -q clang && echo True || echo False |
There was a problem hiding this comment.
What happened to the static check for clang we tried last week?
There was a problem hiding this comment.
I've pushed it separately in #216 because it essentially changes API.
fricklerhandwerk
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses current problems with Rust example on macOS, mainly by changing clang parameters in CC toolchain:
libiconvlibstdc++from GCC that isn't available on macOS tolibc++from clangFixes #187