-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating coverage output for Haskell tests #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibou
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Am going to review tomorrow. |
mboes
previously requested changes
Feb 12, 2019
Profpatsch
suggested changes
Feb 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few trivial and one quoting/templating improvement.
Profpatsch
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work towards a code coverage solution for Haskell in Bazel. Running this is done best in this form:
bazel coverage //tests/two-libs:two-libs -s --test_output=all
This will show you the coverage report of the chosen
haskell_test
rule. This is not the standard Bazel coverage report, but instead a custom-made solution to get around the current restrictions forbazel coverage
's report-collection capabilities.However, the above won't do anything on its own. To get a coverage report for a
haskell_test
, you must establish a required base level of coverage, like this:This will require expression coverage >= 80%. Only expression coverage is currently supported, for simplicity.
I have noted that not all of the test rules pass yet with this new functionality, but I don't know if immediately handling complex cases is the best approach. My proposal is that we incrementally improve the flexibility of Haskell code coverage in Bazel. After all, it has worked for 0% of the test cases until now.
two-libs
is an example of a test case which works.