Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build breakage on macOS when XCode is not installed. #223

Merged
merged 3 commits into from
May 1, 2018
Merged

Fix build breakage on macOS when XCode is not installed. #223

merged 3 commits into from
May 1, 2018

Commits on Apr 30, 2018

  1. Fix build breakage on macOS when XCode is not installed. 

    If the macOS "command-line developer tools" are installed, but XCode
is not, then Bazel will make `ar_executable` point to `/usr/bin/libtool`
(despite the fact that `ar` and `libtool` are not invoked the same way).
https://github.com/bazelbuild/bazel/blob/71932dd4e25d5e755cb8ce12f4dece438c4b5cb1/tools/cpp/unix_cc_configure.bzl#L101

Fix it by checking for that case and overriding it to point to `/usr/bin/ar`
(which is a path also hard-coded in the above code).  This is not ideal, but I don't
know a good way around it.

Note that `rules_rust` has done a similar workaround:
https://github.com/bazelbuild/rules_rust/blob/df95c3e3cd5afd87a69fa71dc9a56a0d0baa7823/rust/toolchain.bzl#L18
    @judah
    judah committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    ad7478c View commit details
    Browse the repository at this point in the history

  2. Fix bug in if logic

    @judah
    judah committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    cd5d40c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Add link to upstream ticket in code.

    @mboes
    mboes committed May 1, 2018
    Configuration menu
    Copy the full SHA
    32fb4c5 View commit details
    Browse the repository at this point in the history