Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ghc 9.8.1 #2132

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Support for ghc 9.8.1 #2132

merged 10 commits into from
Mar 5, 2024

Conversation

ylecornec
Copy link
Member

@ylecornec ylecornec commented Mar 1, 2024

This PR adds support for ghc 9.8.1

In particular:

This function now emits a deprecation warning with ghc 9.8.1
This dependency is not needed since ghc 9.6
Folder names for packages now have an additional suffix which can be a hash, or `-inplace` 
See https://gitlab.haskell.org/ghc/ghc/-/issues/23788
As with 9.6.2 proto-lens-protoc fails with an access violation error

See issue 2131
@ylecornec ylecornec marked this pull request as ready for review March 1, 2024 16:08
@ylecornec ylecornec requested a review from avdv as a code owner March 1, 2024 16:08
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@ylecornec ylecornec added the merge-queue merge on green CI label Mar 5, 2024
@mergify mergify bot merged commit e97f4e4 into master Mar 5, 2024
110 checks passed
@mergify mergify bot deleted the ylecornec/ghc_9_8_1 branch March 5, 2024 08:42
@mergify mergify bot removed the merge-queue merge on green CI label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants