chore: disable flaky test that fails with ExitFailure (-9)
#2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
reviewed
Dec 22, 2023
cgrindel
force-pushed
the
cg/more_oom_fixes
branch
from
6d0b58d to
8918cb6
Compare
avdv
reviewed
Jan 5, 2024
avdv
approved these changes
Jan 5, 2024
cgrindel
added
merge-queue
cgrindel
added
merge-queue
cgrindel
changed the title
ExitFailure (-9)
|
@avdv For now, I recommend that we disable the test that exhibits the error. I will continue my investigation. However, these errors are hindering other work items. Hence, I am asking for another code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this conversation, to prevent out-of-memory (OOM) errors, we will shut down Bazel servers started by
RunTests.hs. Unfortunately, we still see occasionalExit Code: ExitFailure (-9)errors. Printing the memory/process information in CI will provide additional details when/if it occurs, again.RunTests.hsso that tests for each workspace live under a separatedescribe.afterAll_hook to shutdown Bazel after all of the tests for a workspace.around_hook to print memory/process information before and after each test. This is enabled by setting the environment variableRHT_PRINT_MEMORYtotrue.Related to #2089.