Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency io_bazel_rules_go to v0.43.0 #2016

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency io_bazel_rules_go to v0.43.0 #2016

wants to merge 1 commit into from

Conversation

avdv
Copy link
Member

@avdv avdv commented Nov 7, 2023 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
io_bazel_rules_go http_archive minor v0.39.1 -> v0.43.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

bazelbuild/rules_go (io_bazel_rules_go)

v0.43.0

Compare Source

Breaking x/tools upgrade

This change includes a breaking upgrade to golang.org/x/tools

Please make sure to upgrade x/tools to version v0.15.0 to ensure compatibility with rules_go's NoGo.

If you need to use an older version of x/tools (v0.13.0 or earlier), apply the following patch to rules_go:
x-tools.patch

What's Changed
New Contributors

Full Changelog: bazelbuild/rules_go@v0.42.0...v0.43.0

v0.42.0

Compare Source

What's Changed

Added patches to go_download_sdk:

Patches can now be applied to the standard library using go_download_sdk (and go_sdk.download for Bzlmod).

Example:

    go_download_sdk(
        name = "go_sdk",
        sdks = {
            "linux_amd64": (
                "go{}.linux-amd64.mirror6598503.tar.gz".format(go_version),
                "3f5c50e592d8845d30eebd08ddb9c670fd2d909e032b6c2b83ecf97afb34660c",
            ),
            "darwin_arm64": (
                "go{}.darwin-arm64.mirror6598503.tar.gz".format(go_version),
                "fbe78beee7861da09de9319498a1521bc41a8b79d3ead2218ce307b9fa5503e5",
            ),
        },
        patches = [
            "//patches:golang_osx_dns_workaround.patch",
        ],
        urls = ["https://dl.google.com/go/{}"],
        version = go_version,
    )

Other changes included:

Full Changelog: bazelbuild/rules_go@v0.41.0...v0.42.0

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "91585017debb61982f7054c9688857a2ad1fd823fc3f9cb05048b0025c47d023",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.42.0/rules_go-v0.42.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.42.0/rules_go-v0.42.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.1")

v0.41.0

Compare Source

What's Changed

Starting this release, rules_go no longer ship with @go_googleapis repo. Together with Gazelle v0.32.0, it means that all Go code importing generated code from Google APIs will depend on @org_golang_google_genproto, which is resolved by Go modules. For proto files importing Google APIs proto and generating Go code, users need to:

  1. Add an http_archive rule to download Google APIs, e.g.,
http_archive(
    name = "googleapis",
    sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88",
    strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922",
    urls = [
        "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip",
    ],
)

load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language")

switched_rules_by_language(
    name = "com_google_googleapis_imports",
)

Note that the version of Google APIs archive needs to be compatible with the pre-generated code in @org_golang_google_genproto.

  1. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files:
### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto
### gazelle:resolve proto go google/rpc/status.proto  @​org_golang_google_genproto//googleapis/rpc/status
### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto
### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning

Other changes included in this release

Full Changelog: bazelbuild/rules_go@v0.40.1...v0.41.0

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "278b7ff5a826f3dc10f04feaf0b70d48b68748ccd512d7f98bf442077f043fe3",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.20.5")

v0.40.1

Compare Source

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "51dc53293afe317d2696d4d6433a4c33feedb7748a9e352072e2ec3c0dafd2c6",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.40.1/rules_go-v0.40.1.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.20.5")

Changes

This patch release cherry-picked two bug fixes related to Go package driver from master

v0.40.0

Compare Source

What's Changed

New Contributors

Full Changelog: bazelbuild/rules_go@v0.39.1...v0.40.0

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "bfc5ce70b9d1634ae54f4e7b495657a18a04e0d596785f672d35d5f505ab491a",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.40.0/rules_go-v0.40.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.40.0/rules_go-v0.40.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.20.5")

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@avdv
Copy link
Member Author

avdv commented Nov 8, 2023

This currently fails for the nixpkgs builds with:

panic: rulesGoStdlibPrefix should have been set via -X

This was fixed upstream in tweag/rules_nixpkgs#422

@avdv avdv mentioned this pull request Nov 10, 2023
Merged
1 task
@avdv avdv added the blocked Blocked on an usptream ticket label Nov 10, 2023
@avdv avdv force-pushed the renovate/io_bazel_rules_go-0.x branch from a2eb6c9 to 5f2d734 Compare November 21, 2023 14:42
@avdv avdv changed the title chore(deps): update dependency io_bazel_rules_go to v0.42.0 chore(deps): update dependency io_bazel_rules_go to v0.43.0 Nov 21, 2023
@renovate renovate bot force-pushed the renovate/io_bazel_rules_go-0.x branch from 5f2d734 to 220556b Compare March 27, 2024 10:20
@avdv avdv closed this Apr 12, 2024
@avdv avdv deleted the renovate/io_bazel_rules_go-0.x branch April 12, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked Blocked on an usptream ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@avdv