Refactor --config setup
#1301
Merged
Refactor --config setup
#1301
+156
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define top-level configurations for the user to specify, e.g. `--config linux-nixpkgs`. These will then define the required flags for that platform/toolchain combination. Configure CI by writing `--config` flags to `.bazelrc.local` instead of passing them on the command-line. This makes sure that the same configuration is used even if Bazel is called indirectly through a script. This is useful for tools like `ghcide` and `hie-bios`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_haskellrequires different build configuration depending on the platform (Linux, MacOS, Windows) and the way of fetching the GHC distribution (nixpkgs,bindist). This PR makes sure that all this configuration is defined in.bazelrcand is easily accessible for developers through a top-level configuration, e.g.--config linux-nixpkgs. This avoids configuration issues as described in #1173 (comment).Additionally, CI is configured by writing the required
--configflags to.bazelrc.localinstead of passing them on the command-line on eachbazelinvocation. This makes sure that the same configuration is used even if Bazel is called indirectly through a script. This is useful for tools likeghcideandhie-bios, see #1262.