Cabal: Add RUNPATH entries for transitive C library dependencies #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
approved these changes
Mar 24, 2020
thufschmitt
added
merge-queue
|
@Profpatsch @aherrmann, any idea why this isn't picked-up by the merge bot? |
|
/azp run |
|
Azure didn't pick it up. |
GHC passes `-l` flags for all transitive C library dependencies when linking. Accordingly, we need to provide `RUNPATH` entries for all transitive C libraries. Also, to ensure that binaries can find their dynamic library dependencies, we add them to the `runfiles` attribute of the `DefaultInfo` provider.
Regression test for Cabal binary targets not including RUNPATH entries for transitive C library dependencies.
mboes
force-pushed
the
cabal-binary-runpath
branch
from
063e8a4 to
8a88b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RUNPATHentries for all transitive C library dependencies to Cabal targets. GHC passes-lflags for all transitive C library dependencies when linking. Accordingly, we need to provideRUNPATHentries for all transitive C libraries. Also, to ensure that binaries can find their dynamic library dependencies, we add them to therunfilesattribute of theDefaultInfoprovider.Also, make static Haskell libraries available in Cabal build action, so that Cabal binaries can link statically against Haskell libraries.
Extends the test-case introduced in #1267 to test for
RUNPATHentries to transitive C library dependencies in Cabal binary targets.