Improving testing framework and adding the capability to predicate on resulting log #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there another branch than main to use as a target in Github for this PR in order to improve readability of the diff and only show the changes related to this PR? |
mmontin
changed the title
florentc
approved these changes
Sep 11, 2024
| @@ -279,6 +114,9 @@ instance IsProp Bool where | |||
| testConjoin = and | |||
| testDisjoin = or | |||
|
|
|||
| -- * Extra HUnit assertions | |||
There was a problem hiding this comment.
What are those exactly. Do we ever need them?
There was a problem hiding this comment.
They are used in some testing modules. They used to be in some sort of a utility module in tests which was removed a while ago.
There was a problem hiding this comment.
Ok. What do you think about those?
There was a problem hiding this comment.
I think they are here for a lack of a better location, but they do not create any harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use predicates on results of traces, we need to take into account the logging that happens during the run. This is what this PR aims to achieve.