Refining compilation options #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
Co-authored-by: Florent C. <florentc@users.noreply.github.com>
florentc
reviewed
May 31, 2024
Comment on lines
+63
to
+65
| let a = paysPK (wallet 1) $ Script.lovelaceValueOf 123 | ||
| b = paysPK (wallet 2) $ Script.lovelaceValueOf 123 | ||
| c = paysPK (wallet 3) $ Script.lovelaceValueOf 123 |
There was a problem hiding this comment.
Was there a warning here? Even if not, I approve the change
There was a problem hiding this comment.
This module seems to have undergone more significant changes than what would be expected from a few additional new warnings. Is this normal?
florentc
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refines compilation options so that:
The compilation changes are leading to a lot of new warnings (which should have been present before) which are solved in this PR too (incomplete pattern matching, extraneous imports, etc)