Fix PEP 440 versioning #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the GitHub Actions workflow for publishing development versions to TestPyPI. The changes enhance the version handling logic to properly parse and extract base versions while making the build number extraction more robust.
- Updates workflow name to be more descriptive
- Improves version parsing to handle existing .dev suffixes in pyproject.toml
- Replaces sed-based build number extraction with a more compatible bash approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test-publish.yml |
Updates workflow name to better reflect its purpose |
.github/workflows/scripts/get_latest_build.sh |
Enhances version parsing logic and replaces sed with bash regex for better compatibility |
| BUILD_NUMBERS="$BUILD_NUMBERS ${BASH_REMATCH[1]}" | ||
| fi | ||
| done | ||
| BUILD_NUMBERS=$(echo $BUILD_NUMBERS | tr ' ' '\n' | sort -n) |
There was a problem hiding this comment.
The variable
Suggested change
| BUILD_NUMBERS=$(echo $BUILD_NUMBERS | tr ' ' '\n' | sort -n) | |
| BUILD_NUMBERS=$(echo "$BUILD_NUMBERS" | tr ' ' '\n' | sort -n) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.