Skip to content

Conversation

Perdiga
Copy link
Collaborator

@Perdiga Perdiga commented Jul 8, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 00:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version verification step in the release workflow to run Python under Poetry, ensuring the runtime environment matches how the package is managed.

  • Switches raw python invocation to poetry run python for consistency with Poetry-managed environments.
Comments suppressed due to low confidence (2)

.github/workflows/release.yml:89

  • After printing the error message, the script continues with a successful exit code, so mismatches won’t fail the workflow. Add exit 1 after the echo (inside the if block) to ensure the step fails on version mismatch.
          echo "Error: Package version mismatch. Expected ${{ github.event.inputs.version }}, got $PACKAGE_VERSION"

.github/workflows/release.yml:86

  • [nitpick] Consider using poetry version -s to retrieve the package version directly, which avoids loading module code and simplifies the workflow step.
        PACKAGE_VERSION=$(poetry run python -c "from codeql_wrapper import __version__; print(__version__)")

@Perdiga Perdiga merged commit 87badc4 into main Jul 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant