check: Add function for parsing import names for local packages #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nour-Mws
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Wow this was easier than I expected. importlib really does miracles for us!
I think the failing CI is closely related to the issue I was having in #133.
I am only commenting here as I am not sure I understand the motivation behind the choices to let the mapping function fall back to identity mapping.
vreuter
previously requested changes
Feb 13, 2023
jherland
force-pushed
the
jherland/top_level.txt-parser
branch
2 times, most recently
from
bfe4fdd to
86568cd
Compare
Nour-Mws
approved these changes
Feb 14, 2023
mknorps
approved these changes
Feb 14, 2023
4 tasks
jherland
force-pushed
the
jherland/top_level.txt-parser
branch
from
86568cd to
c0be3eb
Compare
This adds find_import_names_from_package_name() which will use importlib.metadata to look up a package name (e.g. a dependency name) in the current Python environment, and attempt to find the corresponding import names that this package provides. If the package does not exist in the local environment, or if importlib.metadata is not able to find any provided import names, we return `None`, and expect the caller to fall back to some other mechanism to map the package name into import name(s).
jherland
force-pushed
the
jherland/top_level.txt-parser
branch
from
c0be3eb to
bfb7f5f
Compare
jherland
dismissed
vreuter’s stale review
Agreed in today's meeting that this PR is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds find_import_names_from_dep() which will look up a dependency
name in the current Python environment, parse its top_level.txt file (if
it exists), and return the resulting import names made available by this
package.
If the package does not exist in the local environment, or if the
top_level.txt file does not exist for this package, we fall back to the
identity mapping, that is, returning the dependency name itself as an
import name.