Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout: icon from frontmatter as it's not needed #1287

Merged
merged 2 commits into from
May 5, 2022
Merged

Remove layout: icon from frontmatter as it's not needed #1287

merged 2 commits into from
May 5, 2022

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Apr 20, 2022

No description provided.

@XhmikosR
Copy link
Member

XhmikosR commented May 5, 2022

When we initially set up Hugo, we didn't make proper use of the template hierarchy hence this key.

BTW, feel free to tweak our layouts more. Ideally, we should follow the hierarchy and eventually offer tag and category pages later :)

@XhmikosR
Copy link
Member

XhmikosR commented May 5, 2022

We don't have a Cloudflare Pages preview, but the change LGTM. We can always revisit if something breaks.

@XhmikosR XhmikosR changed the title Remove layout: icon from frontmatter (not needed) Remove layout: icon from frontmatter as it's not needed May 5, 2022
@XhmikosR XhmikosR merged commit cfb718f into twbs:main May 5, 2022
@XhmikosR XhmikosR added the docs Improvements or additions to documentation label May 5, 2022
@coliff coliff deleted the remove-layout-icon-front-matter branch May 5, 2022 06:02
@coliff
Copy link
Contributor Author

coliff commented May 5, 2022

BTW, feel free to tweak our layouts more. Ideally, we should follow the hierarchy and eventually offer tag and category pages later :)

Yep, I'd be happy to help out a bit more on the site side of things. I think it'd be great to get #731 finished and merged. I was thinking that being able to click on the category name from each icon page could then show the filtered search results. e.g.
https://icons.getbootstrap.com/?category=arrows

@korki43
Copy link
Contributor

korki43 commented May 9, 2022

I think it'd be great to get #731 finished and merged.

We are waiting for #706 to be finished. There are still some open points to discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants