do not append tooltips and popovers to body. This fixes z-index issues: ...

[demike]

...#5070, #5014, #5043, #4914, #4980

[mattlunn]

Correct me if I'm wrong, but this change will prevent tooltips and popovers working on all elements which have a parent which has css overflow set to hidden, as the tooltip/ popover will render outside the bounds of the element.

Because of this, I don't think this is the correct way to address the issue.

1. The in option isn't even documented. If it gets documented, more people might use it.
2. Addition of a parent option (which could be set to document.body, or the elements parent would be more flexible

[demike]

about overflow:hidden parent : as the tooltips are position:absolute this should work. but if the parent has set overflow:hidden and position:relative then the content is cut off.

[mattlunn]

Ahh, that's for clearing that up demike... My setup was using position relative on a parent, which explains why I was seeing that behaviour!

[demike]

Yeah that's the bad thing about that, but it solves a lot of issues with the current z-index ... setup
An alternative solution would be to create a z-index stack js class (I use a z-index counter for the modals for now and it works pretty well ) and move everything to body, but that brings up problems like:

• close the modal --> tooltip of modal content is shown even after the dialog was closed
• do an ajax update on a dom region where a modal was initial (now attached to body) --> duplicate modal (I see this problem in the QCubed php framework)

If you want to see an example of nested dialogs and opening multiple dialogs: just download the source and load
modaltest_z-index_test.html

The absolute positioned modal was added to this pull request accidentally, I pushed it to the wrong branch

[andrewdeandrade]

Hey @demike,

Thanks for opening this pull-request! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

• should always include a unit test if changing js files

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

[Ninir]

@demike Could you please merge the latests 2.1.2-wip branch and rebase yours please? it will be clearer to see what has really changed or not

[ihor-sviziev]

Now i have problems with popup on click to radio button(http://twitter.github.com/bootstrap/javascript.html#buttons - Radio). Last child has not border radius. I think we need add config attribute for change insert popup after element or append to body.

[Yohn]

@igor-svizev please see my pull request - #5768

[rmeschian]

Can I suggest an 'appendTo' option be added, which takes a selector and appends the popover to it? This is what the jquery-ui dragging stuff does.